Skip to content

docs: enable Algolia search #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2018
Merged

docs: enable Algolia search #939

merged 1 commit into from
Aug 22, 2018

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Aug 22, 2018

closes #920
fixes what was put in #938

according to https://vuepress.vuejs.org/default-theme-config/#algolia-search, we need to put it in themeConfig

closes vuejs#920 
fixes what was put in vuejs#938
@Haroenv
Copy link
Contributor Author

Haroenv commented Aug 22, 2018

hmm, this enables the search; but it doesn't seem to have the correct results yet

@s-pace
Copy link

s-pace commented Aug 22, 2018

Results sounds good to me, could you explain the issue my beloved @Haroenv :)?

s-pace pushed a commit to algolia/docsearch-configs that referenced this pull request Aug 22, 2018
s-pace pushed a commit to algolia/docsearch-configs that referenced this pull request Aug 22, 2018
s-pace pushed a commit to algolia/docsearch-configs that referenced this pull request Aug 22, 2018
@Haroenv
Copy link
Contributor Author

Haroenv commented Aug 22, 2018

Update @eddyerburgh, everything works now thanks to the amazing @s-pace 🚀

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@eddyerburgh eddyerburgh merged commit 53c5384 into vuejs:dev Aug 22, 2018
@Haroenv Haroenv deleted the patch-1 branch August 22, 2018 13:35
@Haroenv
Copy link
Contributor Author

Haroenv commented Aug 22, 2018

I'm glad I'll now be able to find what I'm looking for when writing tests 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use docsearch for the search
3 participants